[#208] Home page: sort dropdown, writer filter labels, richer cards#215
[#208] Home page: sort dropdown, writer filter labels, richer cards#215realproject7 merged 2 commits intomainfrom
Conversation
- Replace tab nav with Sort dropdown (custom Select component) - Writer filter: "Human only"→"Human", "Agent only"→"AI" - Filter bar: writer + sort on same row - StoryCard: added date, rating summary, hover bg, improved layout - New SortDropdown.tsx component using Select Fixes #208 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Well-structured changes:
- SortDropdown — Uses existing Select component, builds URL params correctly, preserves writer filter state. Clean.
- StoryCard — Enriched with date (short format), RatingSummary, hover bg, completion badge styled as chip.
flex-collayout for vertical stacking. - WriterFilter — "Human only"→"Human", "Agent only"→"AI". Cleaner labels.
- Home page — Filter bar now flex row with writer filter left, sort dropdown right.
No issues.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The sort dropdown and writer-filter label changes are aligned with issue #208, but the story-card redesign is still materially incomplete. The new cards add date and rating, yet they do not include the required stats row or preview content that the ticket explicitly calls for.
Findings
- [high]
StoryCardis still missing the required price/TVL/24h-change/view-count row and genesis preview, so the home-card redesign is incomplete.- File:
src/components/StoryCard.tsx:17 - Suggestion: Expand the card to include the requested stats row and bottom preview area (with stubs like
—where upstream data is not ready), rather than shipping only title/author/plots/date/rating.
- File:
Decision
Requesting changes because issue #208 explicitly requires richer story cards with stats and preview content, and this PR only delivers a partial subset of that scope.
- New StoryCardStats client component: fetches price + TVL per card - StoryCard accepts optional preview prop (genesis plot first 120 chars) - Home page fetches genesis previews server-side and passes to cards - Stats show compact formatted price and TVL with reserve token label Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up commit completes the missing card work from issue #208 by adding a stats row for price/TVL, server-fetched genesis previews, and explicit stubs for the still-unavailable 24h change and view-count fields. That closes the scope gap from my prior review while keeping the sort-dropdown and writer-filter updates intact.
Findings
- [info] Previous blocking finding resolved.
- File:
src/components/StoryCard.tsx:54 - Suggestion: None.
- File:
Decision
Approving because the home cards now include the required richer content, the missing fields are stubbed consistently where upstream work is not ready, and GitHub validation is passing.
2 participants
Fixes #208 — Sort dropdown replaces tabs, writer filter labels updated (Human/AI), StoryCard enriched with date + rating. New SortDropdown component.